Minecraft CurseForge

Loving the new experience with this, Sounds extended and shaders. Thanks man!

Can't wait for 1.12 support! 

I'm loving this mod so far. Minecraft has such a dead world feel without it. I've run into a couple issues, though.

One, the ambient sounds tend to just stop entirely after some length of time. It might be 30 minutes, it might be 4 hours. I could be crazy, but it seems to happen most frequently when I've been underground for a long time. These are the only messages I see emitted by AmbientSounds in the log (these are collected from several different logs over several days):

[20:17:57] [Client thread/INFO]: [com.creativemd.ambientsounds.AmbientSoundEngine:tick:103]: Unexpected ending sound ambientsounds:animals.cricket.cricket c4c6b011-fa02-4798-abb4-b36de8830d97
[20:18:26] [Client thread/INFO]: [com.creativemd.ambientsounds.AmbientSoundEngine:tick:103]: Unexpected ending sound ambientsounds:animals.bird.bird-cold cb83db22-cc41-40e1-9697-139c75b94a4a
[20:18:26] [Client thread/INFO]: [com.creativemd.ambientsounds.AmbientSoundEngine:tick:103]: Unexpected ending sound ambientsounds:animals.cicadas.cicadas 8531df50-7db3-4667-8ea2-58890a5cb506
[20:18:27] [Client thread/INFO]: [com.creativemd.ambientsounds.AmbientSoundEngine:tick:103]: Unexpected ending sound ambientsounds:animals.cricket.cricket b70cbf0a-8623-4468-a39f-b41a775df16b

[...]

[13:16:07] [Client thread/INFO]: [com.creativemd.ambientsounds.AmbientSoundEngine:tick:103]: Unexpected ending sound ambientsounds:animals.cicadas.cicadas 1304d38d-f2a4-434f-ab7a-c6ed8a373ecc
[13:16:44] [Client thread/INFO]: [com.creativemd.ambientsounds.AmbientSoundEngine:tick:103]: Unexpected ending sound ambientsounds:animals.cricket.cricket-warm-night 9134c1d1-a40f-4097-9eca-5aa3dbdf6a1a
[13:34:11] [Client thread/INFO]: [com.creativemd.ambientsounds.AmbientSoundEngine:tick:103]: Unexpected ending sound ambientsounds:suspense.cave 32086405-65d8-4e29-97fa-ca336c194281

I run a small server for 3 or 4 of my friends, and I believe we all experience this. I can provided a mod list if you'd like, but it's pretty substantial.

Second issue: we have an enormous house, and we get the cave ambient any time we're inside it. I poked at the source code a bit and it looks like the condition for this is being more than 10 blocks below the average height of the world (but above 0). I didn't sift much further, so I'm not sure what size and shape of area it samples for the average. Pretty much our house is so large that it raises the average world height around us enough that we are "underground" whenever we're inside it.

This seems like a pretty good heuristic in general, but I think a slight tweak might help with this kind of situation without significantly impacting performance. For one, I would use the median height rather than the average height, if that's not already the case (sometimes people say "average" when they mean "median" and vice versa, and I didn't dig into the code to find out). This would help filter out small blips in the terrain like ravines, trees, buildings, etc.

Beyond that, I would suggest sweeping down from the skybox until you find the first natural block (dirt, water, smooth stone etc.) rather than just the first non-air block when determining the height of an x,z column. Of course, some players might make very large bases with roofs of smooth stone or hardened clay, but that's probably an edge case.

Anyway, fantastic work so far. I almost hate to raise issues, but I really like this mod and want it be as good as possible.

In reply to CreativeMD:

I like this because it's much cleaner than Dynamic surroundings and support mods like GC, Dynamic surroundings crashes with it, thanks!

so much spam in logs had to revert back to v1

In reply to CreativeMD:

In reply to Hypsellis: